fix(settings): validate the add-provider wizard step before advancing (#2813) by leorivastech · Pull Request #3100 · pingdotgg/t3code

leorivastech · 2026-06-16T07:00:16Z

In the "Add provider instance" dialog, the Next button moved you to the next
step without checking anything. So if you leave the Instance ID empty (or
invalid) on the Identity step and click Next, the wizard happily advances — and
you only find out at the very end, where "Add instance" silently does nothing.
From the user's side it looks like a dead button with no explanation.

The fix gates advancing on the current step. The Identity step now refuses to
advance while the Instance ID is invalid and surfaces the inline error that
already exists — the same check "Add instance" applies before submitting. Steps
that don't own the Instance ID are unaffected, and once the id is valid Next
works as before.

I pulled the navigation decision into a small pure function
(advanceInstanceWizard) so the rule is testable on its own, matching how
validateInstanceId is already structured in this file. Added unit tests covering:
leaving the Driver step with an invalid id (allowed), being blocked on the
Identity step with an invalid id, advancing once it's valid, and not advancing
past the last step. typecheck, lint and formatting are clean.

Happy to add a short before/after screen recording if that helps.

Note

Low Risk
Settings UI-only validation and navigation refactor with no server or persistence changes beyond existing save checks.

Overview
Add provider instance wizard no longer advances past Identity with an invalid instance ID. Next and clicking the Config step header both go through shared resolveWizardNavigation logic; blocked moves stay on Identity and flip hasAttemptedSubmit so the existing inline error shows. Driver → Identity and backward navigation are unchanged.

Wizard step labels move into AddProviderInstanceWizardSteps, with aria-current="step" on the active step. Step list and navigation rules live in AddProviderInstanceDialog.logic.ts with unit tests for block/skip/advance/clamp behavior.

^{Reviewed by Cursor Bugbot for commit 9f399ae. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Validate the add-provider wizard Identity step before advancing to Config

Introduces resolveWizardNavigation in AddProviderInstanceDialog.logic.ts to determine whether wizard navigation should proceed or be blocked based on instance id validation when moving past the Identity step.
Extracts step header rendering into a new AddProviderInstanceWizardSteps.tsx component that delegates click events through resolveWizardNavigation, reflecting step state via aria-current and check icons.
Updates AddProviderInstanceDialog.tsx so the Next button and step header clicks both call applyWizardNavigation, which sets hasAttemptedSubmit on a blocked result to surface the inline validation error.
Behavioral Change: clicking Next or a later step header while the instance id is invalid now redirects to the Identity step instead of advancing.

^{Macroscope summarized 9f399ae.}

coderabbitai · 2026-06-16T07:00:25Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 146fd24d-d60e-4084-ad71-d3406e78fd54

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

macroscopeapp · 2026-06-16T07:02:39Z

Approvability

Verdict: Approved

This is a straightforward bug fix that adds wizard step validation, preventing advancement when instance ID is invalid. The changes are self-contained to settings UI with comprehensive test coverage, and the commit author is the original file maintainer.

^{You can customize Macroscope's approvability policy. Learn more.}

The Next button in the add-provider-instance dialog advanced the wizard unconditionally, so an empty or invalid Instance ID on the Identity step was only caught at the final Add instance step — where it silently no-ops, leaving the user with a dead button and no feedback. Gate advancing on the current step: the Identity step now blocks Next while the Instance ID is invalid and surfaces the existing inline error, matching the check handleSave already applies before submit. Fixes pingdotgg#2813.

Gate both footer and forward step-header navigation through Identity validation while preserving backward navigation. Keep the navigation rule independently testable and surface the existing inline error on blocked skips. Co-authored-by: codex <codex@users.noreply.github.com>

Dismissing prior approval to re-evaluate 9f399ae

…pingdotgg#2813) (pingdotgg#3100) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com>

…pingdotgg#2813) (pingdotgg#3100) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 282ecb3)

…dotgg#2284) (#184) * Sidebar v2 beta: flat thread list with a server-backed settled lifecycle (pingdotgg#4026) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net> (cherry picked from commit 32c6012) * fix(settings): validate the add-provider wizard step before advancing (pingdotgg#2813) (pingdotgg#3100) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 282ecb3) * fix(claude): isolate capability probe from user MCP servers (pingdotgg#4015) Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit aa5ec80) * Preserve connecting status while a turn starts (pingdotgg#4101) Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 783692a) * fix(server): stop restoring stale OpenCode models (pingdotgg#4095) Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 4e09cdd) * [codex] keep scoped package references as text (pingdotgg#4167) Co-authored-by: codex <codex@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> (cherry picked from commit c7b21ff) * fix(web): default provider selection for users without Codex (pingdotgg#4117) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit b6e1b39) * Unify temporary worktree branch naming (pingdotgg#4278) (cherry picked from commit 571a8b4) * fix(web): use message-square icon for settled icon-less project threads in sidebar v2 (pingdotgg#4279) (cherry picked from commit 020179c) * Stabilize sidebar settling animations (pingdotgg#4280) (cherry picked from commit 18b4688) * Restore Copy Link in chat link context menu (pingdotgg#4161) Co-authored-by: Julius Marminge <julius0216@outlook.com> (cherry picked from commit e5fba26) * fix(desktop): handle EPIPE errors on stdout/stderr to prevent crash dialog (pingdotgg#4213) (cherry picked from commit f74eb62) * Preserve draft thread highlighting during promotion (pingdotgg#4283) Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 18fa89c) * Move mobile working timer into the thread timeline (pingdotgg#4285) (cherry picked from commit 7e2bb47) * Stabilize PR status lookups and provider session lifecycle (pingdotgg#4281) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 376c149) * fix: open command palette instead of custom dialog for new thread picker in SidebarV2 (pingdotgg#4269) (cherry picked from commit 9fe4832) * fix(server): don't drop sticky PR fallback when remote URL can't be resolved (pingdotgg#4289) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 9a0a071) * feat(web): copy branch name via right-click in the branch selector (pingdotgg#4275) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 78a0ea5) * Add remote server updates and standalone service management (pingdotgg#4286) Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit ab4a883) * Refine light-mode sidebar surfaces (pingdotgg#4268) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 593289c) * fix(mobile): don't mark Android VPN/Tailscale as offline when connected (pingdotgg#3949) (cherry picked from commit bc9428a) * improve and prevent silent thread branch drift and PR fetching (pingdotgg#2284) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com> (cherry picked from commit 2d31cb0) * fix(sync): restore fork migration IDs under Sidebar v2 settled Upstream pingdotgg#4026 replaced Migrations.ts with linear upstream numbering and dropped fork-only migrations (NormalizeLegacyProviderKinds, RepairProposedPlanColumns, BackfillForkProviderInstanceIds). Restore the fork registry and append ProjectionThreadsSettled as ID 36. Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com> --------- Co-authored-by: Theo Browne <me@t3.gg> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Leonel Rivas <encriptandost@gmail.com> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: codex <codex@users.noreply.github.com> Co-authored-by: Jaret Bottoms <jaretbottoms@gmail.com> Co-authored-by: Ishan <ishansachu1@gmail.com> Co-authored-by: Yukun Shan <92423096+nateEc@users.noreply.github.com> Co-authored-by: Maxwell Young <maxtheyoung@gmail.com> Co-authored-by: Miklós Fazekas <mfazekas@szemafor.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com> Co-authored-by: Henry Zhang <113233555+caezium@users.noreply.github.com> Co-authored-by: Rushikesh Gaikwad <81632222+Wraient@users.noreply.github.com> Co-authored-by: legs <145564979+justsomelegs@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>

github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jun 16, 2026

macroscopeapp Bot previously approved these changes Jun 16, 2026

View reviewed changes

juliusmarminge force-pushed the fix/validate-add-provider-wizard-step branch from 5442d1f to f8fbf84 Compare June 16, 2026 17:31

leorivastech and others added 2 commits July 22, 2026 14:27

juliusmarminge force-pushed the fix/validate-add-provider-wizard-step branch from b1916da to 9f399ae Compare July 22, 2026 12:52

github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels Jul 22, 2026

macroscopeapp Bot approved these changes Jul 22, 2026

View reviewed changes

juliusmarminge merged commit 282ecb3 into pingdotgg:main Jul 22, 2026
16 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(settings): validate the add-provider wizard step before advancing (#2813)#3100

fix(settings): validate the add-provider wizard step before advancing (#2813)#3100
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
leorivastech:fix/validate-add-provider-wizard-step

leorivastech commented Jun 16, 2026 •

edited by macroscopeapp Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 16, 2026 •

edited

Loading

Review skipped

Uh oh!

macroscopeapp Bot commented Jun 16, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

leorivastech commented Jun 16, 2026 • edited by macroscopeapp Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Validate the add-provider wizard Identity step before advancing to Config

Uh oh!

coderabbitai Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

macroscopeapp Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

leorivastech commented Jun 16, 2026 •

edited by macroscopeapp Bot

Loading

coderabbitai Bot commented Jun 16, 2026 •

edited

Loading

macroscopeapp Bot commented Jun 16, 2026 •

edited

Loading